-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
refactor: avoid using lodash where possible #459
Conversation
This pull request introduces 4 alerts when merging 9b81199 into 5384dcf - view on LGTM.com new alerts:
|
Friendly ping @chimurai |
I wish I remember. Probably they were not stable locally even before my changes. |
I plan to continue the effort after merging this PR. |
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
Retry DeepCode |
Using lodash methods does not add value where native methods and operators can be used. In this diff I avoided lodash where possible.
d68abfa
to
4e79852
Compare
Hi @@chimurai is this good to go? |
Hi @TrySound, Thanks for the reminder.
Think it looks good. (Want to do some additional manual testing) |
Some tests errored with unhandled rejection when I debugged code. Promise should be returned there. Nothing need to return explicitly with async await btw. |
Friendly ping @chimurai |
Friendly ping from 2021, is this still in work ? |
Thanks! |
Using lodash methods does not add value where native methods and
operators can be used. In this diff I avoided lodash where possible.
Also fixed a few async tests (returned promise).