Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(proxy): close proxy when server closes #508

Merged
merged 1 commit into from
Mar 28, 2021
Merged

fix(proxy): close proxy when server closes #508

merged 1 commit into from
Mar 28, 2021

Conversation

chimurai
Copy link
Owner

@chimurai chimurai commented Mar 28, 2021

fixes #189
fixes #287

Example Graceful Shutdown (source: https://expressjs.com):

process.on('SIGTERM', () => {
  debug('SIGTERM signal received: closing HTTP server')
  server.close(() => {
    debug('HTTP server closed')
  })
})

More on graceful server shutdown: https://expressjs.com/en/advanced/healthcheck-graceful-shutdown.html

@coveralls
Copy link

coveralls commented Mar 28, 2021

Coverage Status

Coverage decreased (-0.7%) to 87.46% when pulling 32687ee on proxy-close into 7c3fd07 on master.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Graceful Shutdown? how can I shutdown proxy server?
2 participants