Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Fix ProtoBuf conversions for Verification IR #2100

Merged

Conversation

debs-sifive
Copy link
Contributor

@debs-sifive debs-sifive commented Mar 3, 2021

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you update the FIRRTL spec to include every new feature/behavior?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix

API Impact

None

Backend Code Generation Impact

This should allow Verilog to be generated for Verification IR.

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Fixes ProtoBuf conversions for Verification IR.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@ekiwi
Copy link
Contributor

ekiwi commented Mar 4, 2021

This reminds me that the name of print, stop and verification statements might also not be properly serialized to protobuf.

@debs-sifive
Copy link
Contributor Author

This reminds me that the name of print, stop and verification statements might also not be properly serialized to protobuf.

I'm not sure I understand; it doesn't look like these have name fields?

@debs-sifive debs-sifive requested a review from jackkoenig March 4, 2021 00:43
@jackkoenig jackkoenig added this to the 1.4.x milestone Mar 4, 2021
@jackkoenig jackkoenig merged commit 5be1abb into chipsalliance:master Mar 4, 2021
mergify bot pushed a commit that referenced this pull request Mar 4, 2021
@mergify mergify bot added the Backported This PR has been backported to marked stable branch label Mar 4, 2021
@debs-sifive debs-sifive deleted the verif-protobuf-conversions branch March 4, 2021 00:47
@ekiwi
Copy link
Contributor

ekiwi commented Mar 4, 2021

I'm not sure I understand; it doesn't look like these have name fields?

They do now: #2057

And I don't think I actually added them to the protobuf code..

mergify bot added a commit that referenced this pull request Mar 4, 2021
* Fix ProtoBuf conversions for Verification IR (#2100)

(cherry picked from commit 5be1abb)

* waiving issues (#2103)

Co-authored-by: Deborah Soung <debs@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Backported This PR has been backported to marked stable branch bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants