Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Fix width of constant propagation of SInt with zero #2120

Merged
merged 1 commit into from
Mar 14, 2021
Merged

Fix width of constant propagation of SInt with zero #2120

merged 1 commit into from
Mar 14, 2021

Conversation

jackkoenig
Copy link
Contributor

Fixes #2034

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • [NA] Did you update the FIRRTL spec to include every new feature/behavior?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix

API Impact

No impact

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Fixes bug where constant propagation of an SInt with a zero of great width would not properly sign extend the non-zero argument

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig jackkoenig added this to the 1.2.x milestone Mar 14, 2021
@jackkoenig jackkoenig merged commit 0eb7afd into master Mar 14, 2021
@jackkoenig jackkoenig deleted the fix-const-prop-sint-with-zero branch March 14, 2021 08:03
mergify bot pushed a commit that referenced this pull request Mar 14, 2021
@jackkoenig
Fix width of constant propagation of SInt with zero (#2120)
dfaa81a 
(cherry picked from commit 0eb7afd)

# Conflicts:
#	src/main/scala/firrtl/transforms/ConstantPropagation.scala
@mergify mergify bot mentioned this pull request Mar 14, 2021
Open
mergify bot pushed a commit that referenced this pull request Mar 14, 2021
@jackkoenig
Fix width of constant propagation of SInt with zero (#2120)
c268e99 
(cherry picked from commit 0eb7afd)

# Conflicts:
#	src/main/scala/firrtl/transforms/ConstantPropagation.scala
@mergify mergify bot mentioned this pull request Mar 14, 2021
Open
mergify bot pushed a commit that referenced this pull request Mar 14, 2021
@jackkoenig
Fix width of constant propagation of SInt with zero (#2120)
c7a2984 
(cherry picked from commit 0eb7afd)
@mergify mergify bot mentioned this pull request Mar 14, 2021
Merged
@mergify mergify bot added the Backported This PR has been backported to marked stable branch label Mar 14, 2021
mergify bot added a commit that referenced this pull request Mar 14, 2021
@mergify @jackkoenig
Fix width of constant propagation of SInt with zero (#2120) (#2123)
17c2b20 
(cherry picked from commit 0eb7afd)

Co-authored-by: Jack Koenig <koenig@sifive.com>
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@seldridge seldridge seldridge approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported to marked stable branch bugfix
Projects
None yet
Milestone
1.2.x
Development

Successfully merging this pull request may close these issues.

(or, asSInt) extension
2 participants
@jackkoenig @seldridge