Fix issue on kill, process have to consume child output stream or have t... #84

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Open

xsellier wants to merge 1 commit into chjj:master from xsellier:master

xsellier commented Aug 21, 2014

Fix issue on kill, process have to consume child output stream or have to waitpid.

If we don't waitpid spawning a new tty session and then kill it will create a bash zombie process.

root 1795 0.2 9.6 104212 48500 ? Sl 01:00 1:39 node /opt/controller-app/lib/index.js
root 2914 0.1 0.0 0 0 ? Zs 13:22 0:00 _ [bash] <defunct>
root 3137 0.2 0.0 0 0 ? Zs 13:24 0:00 _ [bash] <defunct>


          Fix issue on kill, process have to consume child output stream or hav…

e07d634

…e to waitpid

JamesMGreene mentioned this pull request

Triage existing chjj/pty.js Issues & PRs JamesMGreene/node-partty#1

Open

50 tasks

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet