refactor(service): use unshfit

chnliquan · Sep 1, 2022 · b56684d · b56684d
1 parent 88dd18d
commit b56684d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/service/src/core/plugin-api.ts b/packages/service/src/core/plugin-api.ts
@@ -66,7 +66,7 @@ export class PluginAPI<T extends Service = Service> {
   public registerPresets(source: Plugin[], presets: unknown[]) {
     assert(
       this.service.stage === ServiceStage.InitPresets,
-      `api.registerPresets() failed, it should only used in presets.`,
+      `api.registerPresets() failed, it should only used in presets stage.`,
     )
 
     const plugins = presets.map(
@@ -78,7 +78,7 @@ export class PluginAPI<T extends Service = Service> {
         }),
     )
 
-    source.splice(0, 0, ...plugins)
+    source.unshift(...plugins)
   }
 
   public registerPlugins<T extends string | Plugin>(
@@ -116,7 +116,7 @@ export class PluginAPI<T extends Service = Service> {
     if (this.service.stage === ServiceStage.InitPresets) {
       source.push(...mappedPlugins)
     } else {
-      source.splice(0, 0, ...mappedPlugins)
+      source.unshift(...mappedPlugins)
     }
   }
 

diff --git a/packages/service/src/core/plugin.ts b/packages/service/src/core/plugin.ts
@@ -151,7 +151,7 @@ export class Plugin {
 
     if (isPkgEntry) {
       return nameToKey(
-        Plugin.stripNoneUmiScope(pkgJSON.name as string).replace(
+        Plugin.stripNoneScope(pkgJSON.name as string).replace(
           RE[this.type],
           '',
         ),
@@ -168,10 +168,10 @@ export class Plugin {
   }
 
   public static isPresetOrPlugin(type: PluginType, name: string) {
-    return RE[type].test(Plugin.stripNoneUmiScope(name))
+    return RE[type].test(Plugin.stripNoneScope(name))
   }
 
-  public static stripNoneUmiScope(name: string) {
+  public static stripNoneScope(name: string) {
     if (name.charAt(0) === '@' && !name.startsWith('@eljs/')) {
       name = name.split('/')[1]
     }