Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix spelling mistake in the extract_binary_file_from_assembly function #2776

Closed
gep13 opened this issue Jul 29, 2022 · 1 comment · Fixed by #3070
Closed

Fix spelling mistake in the extract_binary_file_from_assembly function #2776

gep13 opened this issue Jul 29, 2022 · 1 comment · Fixed by #3070

Comments

@gep13
Copy link
Member

gep13 commented Jul 29, 2022

What You Are Seeing?

There is a spelling mistake in the extract_binary_file_from_assembly method.

This was attempted to be fixed as part of #2465 however, @AdmiringWorm noticed that this was a breaking change, so the change has been reverted, and is captured here, to be completed as part of the next major release.

What is Expected?

For there not to be any spelling mistakes 😄

How Did You Get This To Happen? (Steps to Reproduce)

Navigate to the function in the AssemblyFileExtractor.cs file, and see that it uses throwEror rather than throwError.

public static void extract_binary_file_from_assembly(IFileSystem fileSystem, IAssembly assembly, string manifestLocation, string filePath, bool overwriteExisting = false, bool throwEror = true)

System Details

N/A

Output Log

N/A

@gep13 gep13 added this to the 2.0.0 milestone Jul 29, 2022
@gep13 gep13 self-assigned this Jul 29, 2022
@vexx32 vexx32 assigned vexx32 and unassigned gep13 Mar 15, 2023
vexx32 added a commit to vexx32/choco that referenced this issue Mar 15, 2023
Rename method parameter from throwEror -> throwError
gep13 added a commit that referenced this issue Mar 16, 2023
(#2776) Fix AssemblyFileExtractor spelling error
@pauby pauby changed the title Fix spelling mistake in the extract_binary_file_from_assembly function Fix spelling mistake in the extract_binary_file_from_assembly function May 31, 2023
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants