Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

(#508) Add Pester tests for unsupported metadata #2969

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

vexx32
Copy link
Member

@vexx32 vexx32 commented Jan 12, 2023

Description Of Changes

  • Adds some end to end tests for how choco behaves when handling a package with unsupported metadata elements in the nuspec.

Motivation and Context

We should have some tests confirming the end-user behaviour of package installs and packs when choco finds unsupported elements in the nuspec metadata.

Testing

  1. Locally tested with Invoke-Tests.ps1
  2. Tests will be run in TeamCity

The added tests should pass with no issues.

Operating Systems Testing

Win11

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.
  • Tests added

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

#508

@vexx32 vexx32 requested review from gep13 and corbob January 12, 2023 21:53
Adds some end to end tests for how choco behaves when handling a package
with unsupported metadata elements in the nuspec.
@gep13 gep13 force-pushed the tests/unsupported-metadata branch from f1be3e6 to 51a8f8f Compare January 13, 2023 13:07
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 9f1188f into chocolatey:develop Jan 13, 2023
@gep13
Copy link
Member

gep13 commented Jan 13, 2023

@vexx32 thanks for pulling these together!

@vexx32 vexx32 deleted the tests/unsupported-metadata branch January 13, 2023 13:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants