Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

(#3108) Add PR example #3109

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Conversation

pauby
Copy link
Member

@pauby pauby commented Apr 11, 2023

Description Of Changes

Added a great PR example to the CONTRIBUTING.md file.

Motivation and Context

We need a good example to help people when contributing.

Testing

This is just a change to a markdown document.

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

#3108

@gep13 gep13 force-pushed the doc/add-great-pr-example branch from 3a139f7 to 4cd58cf Compare June 9, 2023 08:17
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13
Copy link
Member

gep13 commented Jun 9, 2023

This is simply a change to the contributing document, so we don't need to wait for the CI builds to finish. Going to move forward with merging this.

@gep13 gep13 merged commit cbb1feb into chocolatey:develop Jun 9, 2023
@gep13
Copy link
Member

gep13 commented Jun 9, 2023

@pauby thanks for getting this updated!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants