(#3364) Remove unusable tab completion tests #3552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vexx32
force-pushed
the
fix-tab-completion-tests
branch
from
140b1fe to
14de0ca
Compare
vexx32
changed the title
These tests are verifying the old method and are targeting an implementation detail, rather than actually checking the tab completion results, which the following tests do anyway. As such, we're best off removing them as there is no direct way to check the same things for the Register-ArgumentCompleter method. The tests for the tab completion results themselves cover this adequately already.
vexx32
force-pushed
the
fix-tab-completion-tests
branch
from
14de0ca to
109511d
Compare
corbob
approved these changes
Nov 6, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Remove tab completion tests that are version dependent and aren't really checking anything of particular value to the functionality being tested.
Motivation and Context
These tests are verifying the old method and are targeting an implementation detail, rather than actually checking the tab completion results, which the following tests do anyway.
As such, we're best off removing them as there is no direct way to check the same things for the
Register-ArgumentCompletermethod. The remaining tests for the tab completion results themselves cover this adequately already.Testing
.\Invoke-Tests.ps1 -Tag ProfileOperating Systems Testing
Win10
Change Types Made
Change Checklist
Related Issue
#3364