Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Build process not tagging the assembly information in the built artifacts #21

Closed
corbob opened this issue May 18, 2022 · 0 comments · Fixed by #22
Closed

Build process not tagging the assembly information in the built artifacts #21

corbob opened this issue May 18, 2022 · 0 comments · Fixed by #22
Assignees
Milestone

Comments

@corbob
Copy link
Member

corbob commented May 18, 2022

What You Are Seeing?

When running ./build.ps1 the output DLLs do not have a version number, so they just appear as 0.0.0.0

What is Expected?

The dlls should have a proper version number like 1.5.2

How Did You Get This To Happen? (Steps to Reproduce)

  1. Run ./build.ps1
  2. Open the code_drop folder and find the generated DLLs
  3. Right Click > Properties > Details
  4. Note that the version number is 0.0.0.0

System Details

  • OS Build: 10.0.22000.0 (Windows 11)
  • Windows PowerShell version:
�[32;1mName                           Value�[0m
�[32;1m----                           -----�[0m
PSVersion                      7.2.3
PSEdition                      Core
GitCommitId                    7.2.3
OS                             Microsoft Windows 10.0.22000
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0
  • Chocolatey version (Run choco --version): 1.1.0

Output Log

No output log.

corbob added a commit to corbob/rhino-licensing that referenced this issue May 18, 2022
Remove setting from csproj that was preventing the built DLLs from
being appropriately tagged.

Remove nuspec file as the build process is not using it at all.
corbob added a commit to corbob/rhino-licensing that referenced this issue May 18, 2022
Remove setting from csproj that was preventing the built DLLs from
being appropriately tagged.
@corbob corbob added the Bug label May 18, 2022
@corbob corbob self-assigned this May 18, 2022
vexx32 added a commit that referenced this issue May 18, 2022
(#21) Fix build settings so that DLLs get tagged
@corbob corbob added this to the 1.5.2 milestone Jul 20, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant