Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

It's not live-reloading #420

Closed
laduke opened this issue Feb 13, 2018 · 5 comments
Closed

It's not live-reloading #420

laduke opened this issue Feb 13, 2018 · 5 comments

Comments

@laduke
Copy link
Contributor

laduke commented Feb 13, 2018

😬

  • npx create-choo-app foo
  • npm start
  • edit something (doesn't reload)
  • npm i -S bankai@9.4.0
  • try again

I think it happened between 9.4.0 and 9.4.1, haven't looked deeper.

Hope it's not something weird I did to my dev env.

yours

@goto-bus-stop
Copy link
Member

if it was between 9.4 and 9.4.1 it MAY have been because of this: #392

i'll check it out now

@goto-bus-stop
Copy link
Member

yep it's #392

@goto-bus-stop
Copy link
Member

Live reload kicks in when the documents:index.html node updates; that node updates when scripts:list changes; scripts:list only changes if there was a change in dynamic bundles (from split-require). Maybe it should listen for both scripts:bundle.js and scripts:list, but then we'd get two reloads when you are using split-require 🤔

@goto-bus-stop
Copy link
Member

#443 removes the scripts:list node and instead stores everything on scripts:bundle.js; so it should address this issue too!

@goto-bus-stop
Copy link
Member

Appears to work again since #443 was merged!

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants