Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Expose mime types on graph nodes, fixes #402 #443

Merged
merged 4 commits into from
Mar 14, 2018
Merged

Conversation

goto-bus-stop
Copy link
Member

This depends on yoshuawuyts/buffer-graph#11

Graph nodes now get a .mime property in addition to .buffer and .hash. Fastify can use this to set the content-type header.

@yoshuawuyts
Copy link
Member

yoshuawuyts/buffer-graph#11 was merged!

@goto-bus-stop
Copy link
Member Author

@yoshuawuyts 🙌 LGTY?

Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@goto-bus-stop goto-bus-stop merged commit a9cf41f into master Mar 14, 2018
@goto-bus-stop goto-bus-stop deleted the buffer-graph-meta branch March 30, 2018 13:22
goto-bus-stop added a commit that referenced this pull request Apr 25, 2018
When #443 was merged, it moved the list of dynamic bundle names to a
metadata property on the `scripts:bundle` node. However, the `bankai
build` command was never updated to match.
goto-bus-stop added a commit that referenced this pull request May 2, 2018
When #443 was merged, it moved the list of dynamic bundle names to a
metadata property on the `scripts:bundle` node. However, the `bankai
build` command was never updated to match.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants