-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Console panel #468
Merged
Merged
Console panel #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh neat! - do you by any chance have any screenshots for this? it sounds pretty great! |
The "Total size" is a bit strange in the tab bar when on the log view. On initial build, all pages are server-rendered, so you get a lot of logs at once. It might be helpful to group them somehow. Or maybe we can somehow prefix each log line with the route name that generated it! |
7b3e790
to
b24451f
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🙋 feature
This implements the 2nd panel for
bankai start
, showing console output from the server rendered app (don't know if there's anything else?).SSR uses a separate Console instance, injected as a global
console
variable using require-with-global. Thatconsole
writes to a stream which is saved by lib/ui.js. Pressing 2 in thebankai start
TUI will switch to the console panel, which is an ansi-scrollbox that renders the saved console output. ansi-scrollbox still needs more features and optimization (it's currently probably very slow for many thousands of lines) but it does sort of work.Checklist
Semver Changes
Minor