Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Console panel #468

Merged
merged 12 commits into from
Jun 1, 2018
Merged

Console panel #468

merged 12 commits into from
Jun 1, 2018

Conversation

goto-bus-stop
Copy link
Member

@goto-bus-stop goto-bus-stop commented Apr 18, 2018

This is a 🙋 feature

This implements the 2nd panel for bankai start, showing console output from the server rendered app (don't know if there's anything else?).

SSR uses a separate Console instance, injected as a global console variable using require-with-global. That console writes to a stream which is saved by lib/ui.js. Pressing 2 in the bankai start TUI will switch to the console panel, which is an ansi-scrollbox that renders the saved console output. ansi-scrollbox still needs more features and optimization (it's currently probably very slow for many thousands of lines) but it does sort of work.

Checklist

  • tests pass
  • tests and/or benchmarks are included
  • documentation is changed or added

Semver Changes

Minor

@yoshuawuyts
Copy link
Member

Oh neat! - do you by any chance have any screenshots for this? it sounds pretty great!

@goto-bus-stop
Copy link
Member Author

now i do!

Main view

image

Log view

image

@goto-bus-stop
Copy link
Member Author

The "Total size" is a bit strange in the tab bar when on the log view.

On initial build, all pages are server-rendered, so you get a lot of logs at once. It might be helpful to group them somehow. Or maybe we can somehow prefix each log line with the route name that generated it!

@goto-bus-stop goto-bus-stop changed the title [WIP] Console panel Console panel May 30, 2018
@goto-bus-stop goto-bus-stop merged commit 91826ab into master Jun 1, 2018
@goto-bus-stop goto-bus-stop deleted the console-panel branch June 1, 2018 10:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants