Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

🐛 Update deprecated package opn #525

Merged
merged 1 commit into from
Jun 22, 2019
Merged

Conversation

perguth
Copy link
Contributor

@perguth perguth commented Jun 6, 2019

This somewhat of a 🐛 bug fix.

"The package has been renamed to open"


For me updating the dependency also solved the bug where inspect would break because it couldn't open a browser window (thanks @goto-bus-stop for pointing it out ✨).

user@computer ~/software-v2/node $ npm run inspect

> software-v2@1.0.0 inspect /home/user/software-v2/node
> bankai inspect client.js

/tmp/1559101935126.html
(node:2571) UnhandledPromiseRejectionWarning: Error: Exited with code 3
    at ChildProcess.cp.once.code (/home/user/software-v2/node/node_modules/opn/index.js:85:13)
    at Object.onceWrapper (events.js:281:20)
    at ChildProcess.emit (events.js:193:13)
    at maybeClose (internal/child_process.js:999:16)
    at Socket.stream.socket.on (internal/child_process.js:403:11)
    at Socket.emit (events.js:193:13)
    at Pipe._handle.close (net.js:614:12)
(node:2571) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:2571) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Checklist

  • tests pass

Context

No related issues.

Semver Changes

Patch.

> The package has been renamed to `open`
- https://www.npmjs.com/package/opn
@perguth perguth changed the title Update deprecated package opn 🐛 Update deprecated package opn Jun 6, 2019
Copy link
Member

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 👍

@goto-bus-stop goto-bus-stop merged commit 37a7ece into choojs:master Jun 22, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants