Context #4
Open
Context #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzoschke
commented
Mar 9, 2018
| "fmt" | ||
| "time" | ||
|
|
||
| "github.com/chrismalek/oktasdk-go/okta" | ||
| "github.com/nzoschke/oktasdk-go/okta" |
There was a problem hiding this comment.
We'll want to change these back if this is merged upstream.
|
Give me a day or two to digest this and see how other golang packages handle a breaking change like this. I think I have seen some packages have a "v1" or "v2" import path to handle stuff like this. I am sure it has already been thought out by smart people than me. |
|
For sure. I’m good running off my fork for now.
I believe the GitHub SDK simply dropped the breaking change. This was
justified because the context pattern is a defacto standard now and the
upgrade for users is very easy since there are no actual behavior changes.
…On Fri, Mar 9, 2018 at 12:24 PM Chris Malek ***@***.***> wrote:
Give me a day or two to digest this and see how other golang packages
handle a breaking change like this. I think I have seen some packages have
a "v1" or "v2" import path to handle stuff like this. I am sure it has
already been thought out by smart people than me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAI_0l-Ju-GPNHjmhz8jQPQVevMI-kj8ks5tcuUQgaJpZM4SkovK>
.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the context pattern to the SDK. This is a breaking change to the package API.
However, this preserves the spirit of mimicking the go-github package which introduced context as the first argument to every SDK call in Feb 2017: google/go-github#529
This was prompted by using this SDK in an AWS Lambda function that traces all HTTP activity with X-Ray.