Fixed command output echoing to preserve spaces #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cederberg Thanks for this! ✨ Are you able to add a test for this change at all? Hopefully the examples in If you don't think you'll be able to write a test that's fine, just let me know and I can write a test when I have time. Thanks again! |
Using `IFS= ` when reading lines with `read` ensures that Bash doesn't split words on any characters, but instead returns each line as read. This preserves command output properly, with indentation preserved.
|
Test is now added and verified (i.e breaks on master but not on branch). Thank you for this great utility! |
chrismytton
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
@cederberg Thanks for adding the test, think this is ready to go! 🚀
|
Have tagged v1.1.0 which contains this changes. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
IFS=when reading lines withreadensures that Bash doesn't split words on any characters, but instead returns each line as read. This preserves command output properly, with indentation preserved.Without this change, command output of pretty-printed JSON looks quite ugly for instance.