refactor: resolve is now synchronous

wooorm/import-meta-resolve#15
christophehurpeau · May 8, 2023 · 0551adc · 0551adc
1 parent b4a455e
commit 0551adc
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 12 deletions.
diff --git a/dist/definitions/utils/createGetDependencyPackageJson.d.ts b/dist/definitions/utils/createGetDependencyPackageJson.d.ts
@@ -1,6 +1,6 @@
 import type { PackageJson } from './packageTypes';
 import { internalLoadPackageJsonFromNodeModules, readPkgJson } from './pkgJsonUtils';
-export type GetDependencyPackageJson = (pkgDepName: string) => Promise<PackageJson>;
+export type GetDependencyPackageJson = (pkgDepName: string) => PackageJson;
 type NodeModulesPackagePathCache = Map<string, PackageJson>;
 interface CreateGetDependencyPackageJsonOptions {
     pkgDirname: string;

diff --git a/dist/definitions/utils/createGetDependencyPackageJson.d.ts.map b/dist/definitions/utils/createGetDependencyPackageJson.d.ts.map
diff --git a/dist/definitions/utils/pkgJsonUtils.d.ts b/dist/definitions/utils/pkgJsonUtils.d.ts
@@ -2,5 +2,5 @@ import type { PackageJson } from './packageTypes';
 export declare function readPkgJson(packagePath: string): PackageJson;
 export declare function writePkgJson(packagePath: string, pkg: PackageJson): void;
 /** @internal */
-export declare function internalLoadPackageJsonFromNodeModules(pkgDepName: string, pkgDirname: string): Promise<PackageJson>;
+export declare function internalLoadPackageJsonFromNodeModules(pkgDepName: string, pkgDirname: string): PackageJson;
 //# sourceMappingURL=pkgJsonUtils.d.ts.map
diff --git a/dist/definitions/utils/pkgJsonUtils.d.ts.map b/dist/definitions/utils/pkgJsonUtils.d.ts.map
diff --git a/src/utils/createGetDependencyPackageJson.ts b/src/utils/createGetDependencyPackageJson.ts
@@ -4,9 +4,7 @@ import {
   readPkgJson,
 } from './pkgJsonUtils';
 
-export type GetDependencyPackageJson = (
-  pkgDepName: string,
-) => Promise<PackageJson>;
+export type GetDependencyPackageJson = (pkgDepName: string) => PackageJson;
 
 type NodeModulesPackagePathCache = Map<string, PackageJson>;
 
@@ -25,7 +23,7 @@ export function createGetDependencyPackageJson({
   internalCustomLoadPackageJsonFromNodeModules = internalLoadPackageJsonFromNodeModules,
   internalReadPkgJson = readPkgJson,
 }: CreateGetDependencyPackageJsonOptions): GetDependencyPackageJson {
-  return async (pkgDepName) => {
+  return (pkgDepName) => {
     const existing = nodeModulesPackagePathCache.get(pkgDepName);
     if (existing) return existing;
     let pkg: PackageJson;
@@ -34,7 +32,7 @@ export function createGetDependencyPackageJson({
       pkg = internalReadPkgJson(packagePath);
     } else {
       try {
-        pkg = await internalCustomLoadPackageJsonFromNodeModules(
+        pkg = internalCustomLoadPackageJsonFromNodeModules(
           pkgDepName,
           pkgDirname,
         );

diff --git a/src/utils/pkgJsonUtils.ts b/src/utils/pkgJsonUtils.ts
@@ -11,11 +11,11 @@ export function writePkgJson(packagePath: string, pkg: PackageJson): void {
 }
 
 /** @internal */
-export async function internalLoadPackageJsonFromNodeModules(
+export function internalLoadPackageJsonFromNodeModules(
   pkgDepName: string,
   pkgDirname: string,
-): Promise<PackageJson> {
-  const packageUrl = await importResolve(
+): PackageJson {
+  const packageUrl = importResolve(
     `${pkgDepName}/package.json`,
     `file://${pkgDirname}/package.json`,
   );