Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clean package.json before compiling into source #1003

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Jun 4, 2024

The contents of package.json is compiled into the GitHub Action source code, so we need to clean that up as well.

📦 Published PR as canary version: 11.5.4--canary.1003.9398324441.0

✨ Test out this PR locally via:

npm install chromatic@11.5.4--canary.1003.9398324441.0
# or 
yarn add chromatic@11.5.4--canary.1003.9398324441.0

@ghengeveld ghengeveld requested a review from ethriel3695 June 4, 2024 18:30
@ghengeveld ghengeveld added patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged labels Jun 4, 2024
@ethriel3695
Copy link
Contributor

@ghengeveld I tested this on my vite-project in Chromatic with the Canary.
I used pnpm and node 22 and the GitHub Action workflow passed.
https://github.com/chromaui/vite-project/actions/runs/9390707539/job/25861177410

Copy link
Contributor

@ethriel3695 ethriel3695 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on my repo and it works. See my comment.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 77284061 (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7728406) Report Missing Report Missing Report Missing
Head commit (053500f) 8457 6676 78.94%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1003) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@ghengeveld ghengeveld added release Auto: Create a `latest` release when merged and removed skip-release Auto: Preserve the current version when merged labels Jun 6, 2024
@ghengeveld ghengeveld added this pull request to the merge queue Jun 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 6, 2024
@ghengeveld ghengeveld added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit bb8d829 Jun 6, 2024
26 of 29 checks passed
@ghengeveld ghengeveld deleted the clean-package-json-dist branch June 6, 2024 09:17
@ghengeveld
Copy link
Member Author

🚀 PR was released in v11.5.3 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Jun 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants