Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add missing skipUpdateCheck option to config schema #1011

Conversation

ryan-case-ml
Copy link
Contributor

Addresses #1010

@thafryer thafryer added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Jul 6, 2024
@ryan-case-ml
Copy link
Contributor Author

@thafryer i also realized we need to update this in the gha too but im not as sure on how to do that

@ryan-case-ml
Copy link
Contributor Author

Just took a stab at it in 29026c2

thafryer added a commit that referenced this pull request Jul 8, 2024
Copy link
Member

@thafryer thafryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryan-case-ml Thanks for opening a PR for this! There are a few adjustments to be made then it should be ready to ship!

@ryan-case-ml ryan-case-ml requested a review from thafryer July 8, 2024 18:17
Copy link
Member

@thafryer thafryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@thafryer thafryer merged commit b3b9269 into chromaui:main Jul 8, 2024
2 of 5 checks passed
@thafryer
Copy link
Member

thafryer commented Jul 8, 2024

@ryan-case-ml Thanks so much for your contribution!

@ghengeveld
Copy link
Member

🚀 PR was released in v11.5.5 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Jul 8, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants