Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use --stats-json flag for SB 8.0.0+ #1035

Merged

Conversation

jmhobbs
Copy link
Contributor

@jmhobbs jmhobbs commented Sep 10, 2024

At 8.0.0, --webpack-stats-json was renamed to --stats-json

Prefer that option for projects using 8.0.0 or greater.

📦 Published PR as canary version: 11.10.2--canary.1035.10837456245.0

✨ Test out this PR locally via:

npm install chromatic@11.10.2--canary.1035.10837456245.0
# or 
yarn add chromatic@11.10.2--canary.1035.10837456245.0

@jmhobbs jmhobbs added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Sep 10, 2024
@jmhobbs jmhobbs requested review from andrewortwein and a team September 10, 2024 19:41
@jmhobbs jmhobbs self-assigned this Sep 10, 2024
Copy link

codacy-production bot commented Sep 10, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% (target: -1.00%) 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4a04431) 8312 4484 53.95%
Head commit (238f528) 8317 (+5) 4489 (+5) 53.97% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1035) 6 6 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor

@codykaup codykaup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@andrewortwein andrewortwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫🕸️📦 = 👍🏻

@jmhobbs jmhobbs force-pushed the jmhobbs/cap-2186-gha-doesnt-recognize-the-flag-stats-json branch from 6f56ef0 to a8872de Compare September 11, 2024 20:28
@jmhobbs jmhobbs added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
@jmhobbs jmhobbs added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
@jmhobbs jmhobbs added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
@jmhobbs jmhobbs force-pushed the jmhobbs/cap-2186-gha-doesnt-recognize-the-flag-stats-json branch from a8872de to 238f528 Compare September 12, 2024 17:33
@jmhobbs jmhobbs added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit 3d3cc28 Sep 12, 2024
19 checks passed
@jmhobbs jmhobbs deleted the jmhobbs/cap-2186-gha-doesnt-recognize-the-flag-stats-json branch September 12, 2024 19:26
@ghengeveld
Copy link
Member

🚀 PR was released in v11.10.1 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Sep 12, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants