Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix flaky verify timeout test #1044

Conversation

codykaup
Copy link
Contributor

@codykaup codykaup commented Sep 12, 2024

We had a flaky test which tests verify timeouts. We were returning the status PUBLISHED 3 times then IN_PROGRESS (which successfully resolves the verifyBuild() call). Instead, we can always return a PUBLISHED build to avoid the timing issue.

📦 Published PR as canary version: 11.10.3--canary.1044.10848067460.0

✨ Test out this PR locally via:

npm install chromatic@11.10.3--canary.1044.10848067460.0
# or 
yarn add chromatic@11.10.3--canary.1044.10848067460.0

@codykaup codykaup added patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged labels Sep 12, 2024
@codykaup codykaup self-assigned this Sep 12, 2024
Copy link

codacy-production bot commented Sep 12, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0c9674a) 8322 4492 53.98%
Head commit (e2fe5d1) 8322 (+0) 4492 (+0) 53.98% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1044) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codykaup codykaup requested a review from a team September 12, 2024 21:08
@codykaup codykaup force-pushed the cody/cap-2182-node-srctasksverifytestts-verifybuild-times-out-if-build branch from c285c07 to e2fe5d1 Compare September 12, 2024 21:13
@codykaup codykaup added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit 68338db Sep 12, 2024
19 checks passed
@codykaup codykaup deleted the cody/cap-2182-node-srctasksverifytestts-verifybuild-times-out-if-build branch September 12, 2024 21:40
@ghengeveld
Copy link
Member

🚀 PR was released in v11.10.2 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Sep 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
patch Auto: Increment the patch version when merged released Verdict: This issue/pull request has been released skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants