Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable unicorn/prevent-abbreviations ESLint rule #1064

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

codykaup
Copy link
Contributor

@codykaup codykaup commented Sep 30, 2024

Simply enables our unicorn/prevent-abbreviations ESLint rule and fixes any errors that appear. I also allowed/ignored certain errors if it made sense in the context of the project. Let me know if you'd like me to tweak those!

📦 Published PR as canary version: 11.10.5--canary.1064.11110716020.0

✨ Test out this PR locally via:

npm install chromatic@11.10.5--canary.1064.11110716020.0
# or 
yarn add chromatic@11.10.5--canary.1064.11110716020.0

@codykaup codykaup added minor Auto: Increment the minor version when merged skip-release Auto: Preserve the current version when merged labels Sep 30, 2024
@codykaup codykaup self-assigned this Sep 30, 2024
Copy link

codacy-production bot commented Sep 30, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.09% (target: -1.00%) 62.35% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (38a7b49) 8348 4485 53.73%
Head commit (7e28628) 8397 (+49) 4519 (+34) 53.82% (+0.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1064) 324 202 62.35%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor

github-actions bot commented Sep 30, 2024

📦 Package Size: 4180 KB
✅ Compared to main: 0 KB 2f6a0a4 (4180 KB)

@codykaup codykaup requested a review from a team September 30, 2024 14:53
@codykaup codykaup added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit aa83825 Sep 30, 2024
19 of 20 checks passed
@codykaup codykaup deleted the cody/cap-2260-enable-unicornprevent-abbreviations branch September 30, 2024 20:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
minor Auto: Increment the minor version when merged skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants