Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Account for configs when checking exitOnceUploaded in action #1130

Conversation

codykaup
Copy link
Contributor

@codykaup codykaup commented Dec 9, 2024

Fixes #1128

In our Action, we default exitOnceUploaded to false which means any options set in a configuration are ignored. Instead, we can default it to undefined so things parse out later on (and account for config options).

Test runs with this branch:

📦 Published PR as canary version: 11.20.2--canary.1130.12263328287.0

✨ Test out this PR locally via:

npm install chromatic@11.20.2--canary.1130.12263328287.0
# or 
yarn add chromatic@11.20.2--canary.1130.12263328287.0

@codykaup codykaup self-assigned this Dec 9, 2024
@codykaup codykaup added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

📦 Package Size: 5448 KB
✅ Compared to main: 0 KB 383ecdd (5448 KB)

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 0.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (383ecdd) 7298 5027 68.88%
Head commit (740951a) 7298 (+0) 5027 (+0) 68.88% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1130) 1 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codykaup codykaup requested a review from a team December 9, 2024 18:14
@codykaup codykaup changed the title Account configs when checking exitOnceUploaded in action Account for configs when checking exitOnceUploaded in action Dec 10, 2024
@codykaup codykaup added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 842a145 Dec 10, 2024
25 of 27 checks passed
@codykaup codykaup deleted the cody/cap-2453-exitonceuploaded-in-config-ignored-in-chromauiaction branch December 10, 2024 19:28
@chromatic-ci-bot
Copy link
Collaborator

🚀 PR was released in v11.20.1 🚀

@chromatic-ci-bot chromatic-ci-bot added the released Verdict: This issue/pull request has been released label Dec 10, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exitOnceUploaded in config ignored in chromaui/action
3 participants