Tech/allow many args CH-789

[ndelangen]

https://linear.app/chromaui/issue/CH-789/chromatic-cli-should-accept-multiples-of-the-same-argument-and-pick

@zol I think this should fix the issue..

[linear]

CH-789 chromatic-cli should accept multiples of the same argument (and pick the last one provided)

Hi,
so i change my storybook-build script to:
"build-storybook": "nx run kudos:build-storybook --webpack-stats-json storybook-static"

this is the command chromatic run (and write in the log):
nx run kudos:build-storybook --webpackStatsJson=storybook-static --webpackStatsJson=/tmp/chromatic--1923-jCKKqn91uLU5 --outputDir=/tmp/chromatic--1923-jCKKqn91uLU5

and this is the error i get:
The "path" argument must be of type string. Received an instance of Array
———————————————————————————————————————————————
> NX ERROR Running target "kudos:build-storybook" failed
Failed tasks:

- kudos:build-storybook
→ Command failed: npm run --silent build-storybook -- --output-dir /tmp/chromatic--1923-jCKKqn91uLU5 --webpack-stats-json /tmp/chromatic--1923-jCKKqn91uLU5

what i am missing?

maybe it is related to the fact i using nx?

i configure only --webpack-stats-json. it's look like the chromatic add to the script the output-dir option

no i cant, because from version 6 it is not posibile to use --storybook-build-dir and --only-changed together

---

Looks like when you pass the same argument multiple times to the chromatic-cli it breaks. We should simply allow this, and pick the last entry in the array.

[tmeasday]

Small tweak maybe?

[zol]

Progress here looks good. Sadly I don't have the time/expertise to do code reviews anymore so I've taken myself off the list here.

[ghengeveld]

@ndelangen What's the status of this? Perhaps you'll want to revisit something based on @tmeasday's comment?

[ndelangen]

Very strange for the tests to start failing all of a sudden after merging in main? @ghengeveld got any ideas?

[ghengeveld]

Sorry, my bad.

[ghengeveld]

I don't think this PR is going to completely address the problem. For example, in this example, the --webpack-stats-json flag is getting passed to build-storybook twice, and getting rejected as a result. We could tweak the Storybook CLI to deal with that, but really Chromatic should prevent the same flag from getting set twice when it invokes build-storybook. I think we should resolve buildScriptName to the underlying command and strip --output-dir and --webpack-stats-json (and their alias / camelCase form) from that command before invoking it.

[ndelangen]

I see, this PR is still an improvement I guess, a step into the right direction?

[ndelangen]

@ghengeveld could you add your review on this?