Add --storybook-base-dir to support TurboSnap with a prebuilt Storybook originating from a subdirectory
#455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghengeveld
force-pushed
the
ghengeveld/ch-981-incompatible-options---storybook-build
branch
from
79415c7 to
620c24c
Compare
ghengeveld
deleted the
ghengeveld/ch-981-incompatible-options---storybook-build
branch
|
This was released in 6.1.0. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #403
This allows TurboSnap (via
--only-changed) to be used with a prebuilt Storybook (via--storybook-build-diror-d).In case the prebuilt Storybook does not originate from the same location where Chromatic runs, this would result in zero changed stories getting detected, thus running no tests at all. This PR adds
--storybook-base-dirto correct for that.TODO: Show a warning when we detect this discrepancy (using a heuristic) and suggest to use
--storybook-base-dir.