New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

downcase the slug so we don't accidentally treat origin as fork #554

Merged

JonathanKolnik merged 1 commit into main from JonathanKolnik-lowercase-slug-fork-bug

Apr 7, 2022

Contributor

JonathanKolnik commented Mar 25, 2022 •

edited

Loading

if the slug is capitalized we are accidentally treating it as a fork. Always downcasing the getSlug method should prevent that.
https://linear.app/chromaui/issue/CH-1630/chromatic-cli-slug-isnt-downcased


          downcase the slug so we don't accidentally treat origin as fork

cf8328a

JonathanKolnik requested a review from ghengeveld

March 25, 2022 17:08

Contributor Author

JonathanKolnik commented Mar 28, 2022

https://linear.app/chromaui/issue/CH-1630/chromatic-cli-slug-isnt-downcased

ghengeveld approved these changes

View reviewed changes

JonathanKolnik merged commit 402af20 into main

JonathanKolnik deleted the JonathanKolnik-lowercase-slug-fork-bug branch

April 7, 2022 13:34

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet