Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Omit inputs for workflow_dispatch event in GitHub Action #695

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

108EAA0A
Copy link
Contributor

The support for workflow_dispatch added in #311, but it is a pain to set inputs manually.
This should be possible to automate, so I modified the implementation.

@ghengeveld ghengeveld requested a review from tmeasday December 12, 2022 08:26
@108EAA0A 108EAA0A changed the title Omit inputs for workflow_dispatch event in GitHub Action Omit inputs for workflow_dispatch event in GitHub Action Dec 12, 2022
@arikmaor
Copy link

While I'm not on the team, I was about to suggest the same change
Please merge soon 🙏

Copy link

@arikmaor arikmaor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skitterm skitterm requested a review from thafryer January 24, 2023 23:34
Copy link
Member

@thafryer thafryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested this and worked with no issue. I will update you once a new CLI version is released.

@thafryer thafryer merged commit f9ff646 into chromaui:main Feb 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants