-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Better discovery for TurboSnap trace-changed and related directories #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevanoff
reviewed
May 25, 2023
tevanoff
reviewed
May 25, 2023
thafryer
reviewed
May 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We should centralize the long helper text so that we don't have to tweak it in multiple places if changes need to be made.
thafryer
approved these changes
May 26, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds better tracing for diagnosing TurboSnap tracing in sub-directories
Here is the output expanded
The output with Untraced
How to Test
yarn chromatic trace ./libs/shared/ui-components/src/index.js -m expanded
to see the new outputyarn chromatic trace ./libs/shared/ui-components/src/index.js -m expanded -u './bin-src/ui/messages/errors/invalidRepositorySlug.ts'
and verify the untraced output