Use CHROMATIC_PROJECT_TOKEN environment variable rather than hardcoded value
#750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thafryer
force-pushed
the
use-project-token-env-var
branch
from
196de76 to
7ecc167
Compare
|
@thafryer where did we end up with Azure? |
@ghengeveld We are removing it for now. |
tevanoff
approved these changes
Jun 16, 2023
|
✅ Secrets have been cycled |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings our project setup in line with our general advice to not hardcode project tokens.
Before we merge this, Azure Pipelines needs to be configured with the env var.
We should cycle our token once this PR is merged.