Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Modes Suffix to CLI Progress Indicator #803

Merged

Conversation

thafryer
Copy link
Member

@thafryer thafryer commented Aug 24, 2023

With the addition of Modes, the suffix in the progress indicator should indicate when a story/test has a mode, besides the default.

@linear
Copy link

linear bot commented Aug 24, 2023

AP-3520 Update CLI logging to say mode name not viewport

It will output Primary [320px]

when it should output Primary [mobile]

@thafryer thafryer force-pushed the jarel/ap-3520-update-cli-logging-to-say-mode-name-not-viewport branch from 8bcbcf0 to f1b6a11 Compare August 24, 2023 16:21
Copy link
Contributor

@andrewortwein andrewortwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@thafryer thafryer force-pushed the jarel/ap-3520-update-cli-logging-to-say-mode-name-not-viewport branch from f1b6a11 to 8de2e26 Compare August 25, 2023 14:59
@thafryer thafryer merged commit 05ec22d into main Aug 25, 2023
@thafryer thafryer deleted the jarel/ap-3520-update-cli-logging-to-say-mode-name-not-viewport branch August 25, 2023 16:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants