Support untraced flag in dependency tracing fallback scenario (for pnpm) #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethriel3695
approved these changes
Oct 11, 2023
tmeasday
approved these changes
Oct 11, 2023
|
It's been properly tested by the customer, and we have test coverage for the change, so I'm already confident about it. |
ghengeveld
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't honoring the
--untracedflag when doing the fallback dependency tracing usingpackage.jsonrather than the lockfile. This is particularly relevant topnpmprojects since we don't support pnpm lockfiles.📦 Published PR as canary version:
7.4.0--canary.835.6a9277c.0✨ Test out this PR locally via:
npm install chromatic@7.4.0--canary.835.6a9277c.0 # or yarn add chromatic@7.4.0--canary.835.6a9277c.0