Fix ENOENT when uploading stats file with --upload-metadata
#843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghengeveld
changed the title
ENOENT when uploading stats file (metadata)ENOENT when uploading stats file with --upload-metadata
tevanoff
approved these changes
Oct 25, 2023
ghengeveld
added
release
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes
preview-stats.jsoncouldn't be loaded becausestatsPathwouldn't be set correctly if tracing changed files failed or was aborted. This fixes the problem and adds a test for the uploading of metadata files.📦 Published PR as canary version:
7.5.2--canary.843.6652619166.0✨ Test out this PR locally via:
npm install chromatic@7.5.2--canary.843.6652619166.0 # or yarn add chromatic@7.5.2--canary.843.6652619166.0