Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Allow traceChanged in Chromatic config spec #916

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Allow traceChanged in Chromatic config spec #916

merged 1 commit into from
Feb 12, 2024

Conversation

tevanoff
Copy link
Contributor

@tevanoff tevanoff commented Feb 7, 2024 •
edited by ghengeveld
Loading

Add missing traceChanged config option to Chromatic config spec.

📦 Published PR as canary version: 10.9.5--canary.916.7875517873.0

✨ Test out this PR locally via:

npm install chromatic@10.9.5--canary.916.7875517873.0
# or 
yarn add chromatic@10.9.5--canary.916.7875517873.0

@tevanoff tevanoff added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Feb 7, 2024
@tevanoff tevanoff requested a review from thafryer February 8, 2024 16:56
thafryer
thafryer approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@thafryer thafryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was only needed for debugging capabilities. It's meant to be called when triggering the CLI manually for debugging. I see no issue adding it here, though.

@tevanoff tevanoff added this pull request to the merge queue Feb 12, 2024
Merged via the queue into main with commit 1de9402 Feb 12, 2024
22 of 24 checks passed
@tevanoff tevanoff deleted the todd/allow-trace-changed branch February 12, 2024 17:20
@ghengeveld
Copy link
Member

🚀 PR was released in v10.9.4 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Feb 12, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@thafryer thafryer thafryer approved these changes

Assignees
No one assigned
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tevanoff @ghengeveld @thafryer