-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Implement std::iter::Sum for Duration #522
Conversation
The CI is giving me this clippy error that seems unrelated to my code: https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains - any idea why? |
I have opened #525 to allow the lint. |
@jakevossen5 sorry about the delay, I've merged @robyoung 's PR (thanks!), if you rebase on main then the clippy lint should not bother you. |
Should be good for review now! |
Any update on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just going to wait for @quodlibetor to give me the go-ahead before merging.
Any update on this? Thanks! |
Thanks for working on this! |
Thanks for contributing to chrono!
about adding the PR number)
we can't reintroduce it?
Closes #520