Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement std::iter::Sum for Duration #522

Merged
merged 4 commits into from
Jun 9, 2022
Merged

Conversation

jakevossen5
Copy link
Contributor

@jakevossen5 jakevossen5 commented Jan 5, 2021

Thanks for contributing to chrono!

  • Have you added yourself and the change to the changelog? (Don't worry
    about adding the PR number)
  • If this pull request fixes a bug, does it add a test that verifies that
    we can't reintroduce it?

Closes #520

@jakevossen5
Copy link
Contributor Author

The CI is giving me this clippy error that seems unrelated to my code: https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains - any idea why?

@robyoung
Copy link
Contributor

I have opened #525 to allow the lint.

@quodlibetor
Copy link
Contributor

@jakevossen5 sorry about the delay, I've merged @robyoung 's PR (thanks!), if you rebase on main then the clippy lint should not bother you.

@jakevossen5 jakevossen5 marked this pull request as draft January 22, 2021 17:15
@jakevossen5 jakevossen5 marked this pull request as ready for review January 22, 2021 17:16
@jakevossen5
Copy link
Contributor Author

Should be good for review now!

@jakevossen5
Copy link
Contributor Author

Any update on this?

Copy link
Member

@Milo123459 Milo123459 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just going to wait for @quodlibetor to give me the go-ahead before merging.

@stewartallen
Copy link

Any update on this? Thanks!

@djc djc merged commit 7c0bc31 into chronotope:main Jun 9, 2022
@djc
Copy link
Member

djc commented Jun 9, 2022

Thanks for working on this!

@esheppa esheppa mentioned this pull request Jul 27, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Sum type for duration?
6 participants