fixes fromTransformAttribute issue when parsing exponential values

chrvadala · Jan 1, 2021 · c193647 · c193647
1 parent 111592d
commit c193647
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 13 deletions.
diff --git a/src/fromTransformAttribute.autogenerated.js b/src/fromTransformAttribute.autogenerated.js
diff --git a/src/fromTransformAttribute.pegjs b/src/fromTransformAttribute.pegjs
@@ -83,15 +83,15 @@ integerConstant
   = ds:digitSequence { return ds.join(""); }
 
 floatingPointConstant
-  = fractionalConstant exponent?
-    / digitSequence exponent
+  = f:fractionalConstant e:exponent? { return [f, e || null].join("")}
+    / d:digitSequence e:exponent { return [d, e].join("")}
 
 fractionalConstant "fractionalConstant"
   = d1:digitSequence? "." d2:digitSequence { return [d1 ? d1.join("") : null, ".", d2.join("")].join(""); }
     / d:digitSequence "." { return d.join(""); }
 
 exponent
-  =  [eE] sign? digitSequence
+  =  [eE] s:sign? d:digitSequence { return ['e', s, d.join("")].join("") }
 
 sign
   = [+-]

diff --git a/test/fromTransformAttribute.pegjs.spec.js b/test/fromTransformAttribute.pegjs.spec.js
@@ -31,6 +31,21 @@ describe('fromTransformAttribute.pegjs', () => {
     })
   })
 
+  describe('exponential values', () => {
+    it('should parse without errors', () => {
+      // it is tested with rotate function, but it doesn't matter because any parser make use of the same number parser
+      expect(parse('rotate(1e1)')).toEqual([{ type: 'rotate', angle: 1e1 }])
+      expect(parse('rotate(-1e1)')).toEqual([{ type: 'rotate', angle: -1e1 }])
+      expect(parse('rotate(1e-1)')).toEqual([{ type: 'rotate', angle: 1e-1 }])
+      expect(parse('rotate(-1e-1)')).toEqual([{ type: 'rotate', angle: -1e-1 }])
+
+      expect(parse('rotate(1.1e1)')).toEqual([{ type: 'rotate', angle: 1.1e1 }])
+      expect(parse('rotate(-1.1e1)')).toEqual([{ type: 'rotate', angle: -1.1e1 }])
+      expect(parse('rotate(1.1e-1)')).toEqual([{ type: 'rotate', angle: 1.1e-1 }])
+      expect(parse('rotate(-1.1e-1)')).toEqual([{ type: 'rotate', angle: -1.1e-1 }])
+    })
+  })
+
   describe('complex transformations', () => {
     it('should parse in the right order', () => {
       expect(parse('translate(1,2) translate(3,4) translate(5,6)')).toEqual([