Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

narrow return type of applyToPoint(s) function #67

Merged
merged 1 commit into from
Apr 13, 2020
Merged

narrow return type of applyToPoint(s) function #67

merged 1 commit into from
Apr 13, 2020

Conversation

formatlos
Copy link
Contributor

I refined the type definition of the applyToPoint to narrow down the return type to the actually passed Point-type

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 88b79e4 on formatlos:refine-types into 6f900b6 on chrvadala:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 88b79e4 on formatlos:refine-types into 6f900b6 on chrvadala:master.

hijackit
hijackit approved these changes Mar 27, 2020
View reviewed changes
Copy link

@hijackit hijackit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely agree with the proposed change. It would simplify a lot the code, avoiding to perform type-checking every time we need to access the coordinates of a point

@formatlos formatlos mentioned this pull request Mar 28, 2020
Closed
@bgschiller bgschiller mentioned this pull request Apr 9, 2020
Closed
@chrvadala chrvadala merged commit 2eda217 into chrvadala:master Apr 13, 2020
@chrvadala
Copy link
Owner

Released with version 2.3.0. Thanks for your contribution. I added your name in contributors list.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hijackit hijackit hijackit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@formatlos @coveralls @chrvadala @hijackit