-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
v1.14: Upgrade GoBGP to v3.23.0 and backport #28293 #30793
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
backport/1.14
This PR represents a backport for Cilium 1.14.x of a PR that was merged to main.
kind/backports
This PR provides functionality previously merged into master.
labels
Feb 15, 2024
YutaroHayakawa
force-pushed
the
fix-30367-1.14
branch
2 times, most recently
from
February 15, 2024 13:11
803c20a
to
c1b7140
Compare
YutaroHayakawa
requested review from
a team and
ldelossa
and removed request for
a team
February 15, 2024 13:12
/test-backport-1.14 |
Conformance E2E: #30745 |
ldelossa
approved these changes
Feb 15, 2024
youngnick
approved these changes
Feb 15, 2024
To pull-in the upstream change (osrg/gobgp#2761) to fix cilium#30367. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
[ upstream commit 11b01e3 ] Set R-bit in graceful restart negotiation to not to withdraw routes by Receiving Speaker Details is in https://www.rfc-editor.org/rfc/rfc4724.html#section-4.1 Fixes: cilium#28168 Signed-off-by: ArsenyBelorukov <arsenig.n@gmail.com> Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa
force-pushed
the
fix-30367-1.14
branch
from
February 16, 2024 06:27
c1b7140
to
5081b09
Compare
/test-backport-1.14 |
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Feb 16, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
backport/1.14
This PR represents a backport for Cilium 1.14.x of a PR that was merged to main.
kind/backports
This PR provides functionality previously merged into master.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines GoBGP upgrade and the backport of #28293 together solves the GR hanging issue #30367.