Move observer_test_helpers.go to a separate package #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to refactor observer_test_helpers.go as a separate package. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
Some functions in observer_test_helper.go follow the same logic as Tetragon daemon. This was problematic because daemon imports packages that import observer, but Go doesn't allow import cycles. Furthermore, it's conceptually a different functionality than the rest of the observer package. This commit moves observer_test_helper.go file to a separate package: github.com/cilium/tetragon/pkg/observer/observertesthelper. Apart from updating all necessary imports there are no other changes. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
Now that observertesthelper is a separate package, we can import metrics package there. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
lambdanis
force-pushed
the
pr/lambdanis/observer-test-helpers
branch
from
bb3607d to
bd51be3
Compare
kkourt
approved these changes
Aug 9, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit an import cycle in
observer_test_helpers.gowhen working on #1304, so I re-implementedmetrics.EnableMetrics()there instead of importing the metrics package. Then I hit the same import cycle when working on #1279, so here I movedobserver_test_helpers.goto a separate package.It's a pretty straightforward refactoring, see commits for details. Technically it is a breaking change, but only developer-facing.