Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CODEOWNERS: multiple fixes and move file in .github #1449

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

mtardy
Copy link
Member

@mtardy mtardy commented Sep 11, 2023

  • Fix paths, indeed path/ means that it will select /path/ but also /something/path/. So I explicitely mentioned /path/ for the entries.
  • Exclude myself from some auto-generated docs files that are often modified.
  • Add @cilium/tetragon owner to /.github/workflows/ to ping William on workflow changes without blocking PRs.
  • Move file into /.github since it's tied to GitHub and will reduce the amount of files in the root.

cc @willfindlay, tell me if you are satisfied with the changed I did to your line.

@mtardy mtardy added the release-note/ci This PR makes changes to the CI. label Sep 11, 2023
@mtardy mtardy requested a review from willfindlay September 11, 2023 10:40
@mtardy mtardy requested a review from a team as a code owner September 11, 2023 10:40
@mtardy mtardy changed the title CODEOWNERS: multiple fixes and move file in /.github CODEOWNERS: multiple fixes and move file in .github Sep 11, 2023
- Fix paths, indeed `path/` means that it will select `/path/` but also
  `/something/path/`. So I explicitly mentioned `/path/` for the
  entries.
- Exclude myself from some auto-generated docs files that are often
  modified.
- Add @cilium/tetragon owner to `/.github/workflows/` to ping William on
  workflow changes without blocking PRs.
- Move file into `/.github` since it's tied to GitHub and will reduce
  the amount of files in the root.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
@mtardy mtardy force-pushed the pr/mtardy/codeowners-fix branch from c2fe92b to 9ec635e Compare September 11, 2023 10:41
Copy link
Contributor

@willfindlay willfindlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

@mtardy mtardy merged commit 385e519 into main Sep 11, 2023
@mtardy mtardy deleted the pr/mtardy/codeowners-fix branch September 11, 2023 13:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants