Define map metrics as custom collectors #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdanis
force-pushed
the
pr/lambdanis/bpf-metrics
branch
from
5c8eaa0 to
dea9dc2
Compare
lambdanis
added
the
release-note/minor
lambdanis
force-pushed
the
pr/lambdanis/bpf-metrics
branch
from
dea9dc2 to
28bba16
Compare
lambdanis
force-pushed
the
pr/lambdanis/bpf-metrics
branch
2 times, most recently
from
f6f3b32 to
bdd0a0b
Compare
lambdanis
changed the title
lambdanis
force-pushed
the
pr/lambdanis/bpf-metrics
branch
4 times, most recently
from
0968029 to
aa045e9
Compare
These types are slim helpers intended to be used in custom collectors that read metrics directly from BPF maps. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
This commit reimplements two metrics: tetragon_map_in_use_gauge and tetragon_map_errors_total, so that they are exposed by custom Prometheus collectors. This means that metric values are read from BPF maps at the scrape time, without a need for a userland tickers. From the user perspective, the metrics are more accurate. Additionally, the errors metric is exposed as a counter instead of a gauge. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
lambdanis
force-pushed
the
pr/lambdanis/bpf-metrics
branch
from
aa045e9 to
afdcbb9
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements two metrics:
tetragon_map_in_use_gaugeandtetragon_map_errors_total, so that they are exposed by custom Prometheuscollectors. This means that metric values are read from BPF maps at the scrape
time, without a need for a userland tickers. From the user perspective, the
metrics are more accurate.
Additionally, the errors metric is exposed as a counter instead of a gauge.