Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

tracing: check for empty returnArg #1515

Merged
merged 1 commit into from
Sep 28, 2023
Merged

tracing: check for empty returnArg #1515

merged 1 commit into from
Sep 28, 2023

Conversation

kkourt
Copy link
Contributor

@kkourt kkourt commented Sep 27, 2023 •
edited
Loading

If returnArg is empty, but return is true, the agent will crash with a sigsegv. This patch adds a check and returns an error.

Fixes: #1490

fix segfault when return is specified without returnArg in a tracing policy

@kkourt
tracing: check for empty returnArg
3cd8c56 
If returnArg is empty, but return is true, the agent will crash with a
sigsegv. This patch adds a check and returns an error.

Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
@kkourt kkourt requested a review from a team as a code owner September 27, 2023 15:44
@kkourt kkourt requested a review from olsajiri September 27, 2023 15:44
@kkourt kkourt mentioned this pull request Sep 27, 2023
Closed
@kkourt kkourt added the release-note/minor This PR introduces a minor user-visible change label Sep 27, 2023
@kkourt kkourt merged commit 3c21a7b into main Sep 28, 2023
@kkourt kkourt deleted the pr/kkourt/fix-returnarg branch September 28, 2023 19:40
@p-linnane p-linnane mentioned this pull request Nov 1, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tpapagian tpapagian tpapagian approved these changes

@olsajiri olsajiri Awaiting requested review from olsajiri olsajiri is a code owner automatically assigned from cilium/tetragon

Assignees
No one assigned
Labels
release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specifying return: true without returnArg: type: causes a segfault.
2 participants
@kkourt @tpapagian