tetragon: Several observer related cleanups #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olsajiri
added
the
release-note/minor
There's no need to create observer, we can just create the policy and call sensors policy handlers. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Moving TestKprobeOverrideNonSyscall to kprobe_validation_test.go as TestKprobeValidationNonSyscallOverride, because It's pure crd validation test. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
And related GetDefaultObserverWithFileNoTest function and related code, which is no longer used. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
The GetDefaultSensorsWithFile needs to return loaded sensors without observer. This complicates other functions that return observer object with loaded sensors. Implementing GetDefaultSensorsWithFile directly without common code to ease up following changes. Remove ctx argument, because it's no longer needed. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
It's no longer needed, moving it to be directly getDefaultObserver function and not to return any sensor objects. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
olsajiri
force-pushed
the
observer_fixes
branch
from
0d88349 to
7f40476
Compare
kkourt
approved these changes
Oct 2, 2023
| var sensor *sensors.Sensor | ||
|
|
||
| if tp != nil { | ||
| sensor, err = sensors.GetMergedSensorFromParserPolicy(tp) |
There was a problem hiding this comment.
One minor note: I'd like to remove the GetMergedSensorsFromParserPolicy and use everywhere the same code path: parse the policy, get a list of sensors, and we load the sensors. No need to change it now, but something to avoid in the future.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several observer related cleanups.