-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add option to tetra to filter on event types #1549
Conversation
56662a7
to
39aeb06
Compare
5ba3f39
to
3ba593d
Compare
f024511
to
defead4
Compare
Go tests fail but locally they're passing:
Tests locally also fail when running with:
Running tests with:
The following also works:
This as well:
It seems that |
Hey!! Thanks! I have this in the test right now:
So I guess there may be an issue on how the one supposed to fail/do nothing is written or return. |
I did some more testing, and apparently, it's a flake. Because sometimes it works even with:
Result
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should fix your test case failing! :) And a small comment.
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Could you squash your commit into the first one? :) thanks!! take this opportunity to also start the commit message with |
This commit adds the ability to filter on the event types. Signed-off-by: darox <maderdario@gmail.com>
4b43bc2
to
01b4fbc
Compare
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking the time to implement that! :) 🎉 🌮
I'll let @willfindlay approve/merge.
No problem. It was a pleasure to work on the first PR for tetragon. |
This commit adds the ability to filter on the event types.