Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

tetragon: Allow to specify rb-* size options with size suffix #1593

Merged
merged 1 commit into from
Oct 16, 2023
Merged

tetragon: Allow to specify rb-* size options with size suffix #1593

merged 1 commit into from
Oct 16, 2023

Conversation

olsajiri
Copy link
Contributor

Adding support to set and display rb sizes with size suffixes.

  # ./tetragon --bpf-lib ./bpf/objs/ --rb-size-total 256M
  ...
  time="2023-10-13T20:18:51Z" level=info msg="Perf ring buffer size (bytes)" percpu=64M total=256M

  # ./tetragon --bpf-lib ./bpf/objs/ --rb-size 16M
  ...
  time="2023-10-13T20:18:27Z" level=info msg="Perf ring buffer size (bytes)" percpu=16M total=64M

  # ./tetragon --bpf-lib ./bpf/objs/ --rb-queue-size=100K
  ...
  time="2023-10-13T20:17:42Z" level=info msg="Perf ring buffer events queue size (events)" size=976K

@olsajiri olsajiri added the release-note/minor This PR introduces a minor user-visible change label Oct 13, 2023
@olsajiri
tetragon: Allow to specify rb-* size options with size suffix
bbf0344 
Adding support to set and display rb sizes with size suffixes.

  # ./tetragon --bpf-lib ./bpf/objs/ --rb-size-total 256M
  ...
  time="2023-10-13T20:18:51Z" level=info msg="Perf ring buffer size (bytes)" percpu=64M total=256M

  # ./tetragon --bpf-lib ./bpf/objs/ --rb-size 16M
  ...
  time="2023-10-13T20:18:27Z" level=info msg="Perf ring buffer size (bytes)" percpu=16M total=64M

  # ./tetragon --bpf-lib ./bpf/objs/ --rb-queue-size=100K
  ...
  time="2023-10-13T20:17:42Z" level=info msg="Perf ring buffer events queue size (events)" size=976K

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
@olsajiri olsajiri marked this pull request as ready for review October 15, 2023 20:18
@olsajiri olsajiri requested a review from a team as a code owner October 15, 2023 20:18
@olsajiri olsajiri requested a review from kevsecurity October 15, 2023 20:18
mtardy
mtardy approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and useful thanks!! :)

@olsajiri olsajiri merged commit d649199 into cilium:main Oct 16, 2023
@p-linnane p-linnane mentioned this pull request Nov 1, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mtardy mtardy mtardy approved these changes

@kevsecurity kevsecurity Awaiting requested review from kevsecurity kevsecurity is a code owner automatically assigned from cilium/tetragon

Assignees
No one assigned
Labels
release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olsajiri @mtardy