Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add veristat in the CI #1610

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Add veristat in the CI #1610

merged 2 commits into from
Oct 18, 2023

Conversation

mtardy
Copy link
Member

@mtardy mtardy commented Oct 18, 2023

Fixes #892

We can restrict the run to PRs touching the /bpf folder.

Take a look at this and that. More comparison examples here.

@mtardy mtardy added area/ci Related to CI release-note/ci This PR makes changes to the CI. labels Oct 18, 2023
@mtardy mtardy changed the title ci: run veristat on every commits Add veristat in the CI Oct 18, 2023
This new workflow runs veristat on commits that touch the code under the
bpf/ directory in PRs and on main.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
This new workflow displays the comparison of the veristat output between
the base_ref of the branch and the branch. This should give a good idea
of how the PR changes the BPF stats.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
@mtardy mtardy force-pushed the pr/mtardy/add-veristat branch from 839e9ec to 686689d Compare October 18, 2023 13:53
@mtardy mtardy marked this pull request as ready for review October 18, 2023 13:58
@mtardy mtardy requested review from willfindlay and a team as code owners October 18, 2023 13:58
@mtardy
Copy link
Member Author

mtardy commented Oct 18, 2023

since this is analytic, not sure it's entirely relevant if the action fails to PRs validation, maybe I could add continue-on-error just to provide this as "more information" but not as PR "validation". 🤔

Copy link
Contributor

@willfindlay willfindlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks magical

@jrfastab jrfastab merged commit 2ed3bd8 into main Oct 18, 2023
@jrfastab jrfastab deleted the pr/mtardy/add-veristat branch October 18, 2023 19:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/ci Related to CI release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: run veristat tool on every commit
3 participants