Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Arg validation: Add mappings for sock and skb #1807

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

kevsecurity
Copy link
Contributor

Kprobe arguments of type "sock" and "skb" are valid but fail BTF validation because the function prototypes report "struct sock *" and "struct sk_buff *" types.

This commit adds validation to remove warnings that these types in the policy don't match the types in the function prototypes.

Adds validation for sock and skb types

Kprobe arguments of type "sock" and "skb" are valid but fail BTF
validation because the function prototypes report "struct sock *" and
"struct sk_buff *" types.

This commit adds validation to remove warnings that these types in the
policy don't match the types in the function prototypes.

Signed-off-by: Kevin Sheldrake <kevin.sheldrake@isovalent.com>
@kevsecurity kevsecurity added the release-note/bug This PR fixes an issue in a previous release of Tetragon. label Nov 27, 2023
@kevsecurity kevsecurity requested a review from a team as a code owner November 27, 2023 16:45
@kevsecurity kevsecurity requested a review from olsajiri November 27, 2023 16:45
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@kevsecurity kevsecurity merged commit c97da4b into main Nov 27, 2023
@kevsecurity kevsecurity deleted the pr/kevsecurity/fix-sock-skb-validation branch November 27, 2023 17:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/bug This PR fixes an issue in a previous release of Tetragon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants