watcher: Don't create service and podInfo informers #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdanis
force-pushed
the
pr/lambdanis/watcher
branch
7 times, most recently
from
b8b1451 to
d62f19f
Compare
lambdanis
added
area/userspace
lambdanis
force-pushed
the
pr/lambdanis/watcher
branch
2 times, most recently
from
2a2a2dd to
05b1240
Compare
lambdanis
changed the title
Instead of defining each informer as a separate field in K8sWatcher, define informers map as well as AddInformers and GetInformer methods (to populate the map and retrieve informers). This also required changing how the watcher is started - K8sWatcher now contains startFunc function, which is extended in AddInformers method and called in NewK8sWatcherWithTetragonClient. This refactoring will make it easier to extend the watcher with additional informers or to clean them up if needed. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
They are unused. I also merged NewK8sWatcherWithTetragonClient function into NewK8sWatcher and deleted unused code related to these informers. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
Since Start() is now an exported method of K8sWatcher, it makes sense to separate responsibilities of creating and starting the watcher. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
lambdanis
force-pushed
the
pr/lambdanis/watcher
branch
from
05b1240 to
f4e1524
Compare
lambdanis
changed the title
kkourt
approved these changes
Mar 1, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up unused code related to service and podInfo informers.
I also refactored how informers are created in
K8sWatcher, so that it's easier to add additional informers if needed.