metrics: Refactor metrics label filter logic #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdanis
added
area/metrics
Another little refactoring of the metrics label filter logic. The idea behind it is that we can have multiple groups of configurable labels, each one with defaults and helper functions for creating a labels struct. I reorganized the code a bit to enable easy creation of different groups of labels, configurable with different options. Notable changes: * Default label filter is now returned by DefaultLabelsFilter function in pkg/option instead of defining a global variable in pkg/metrics/consts. This is to prevent accidentally mutating the default. * When updating a metric with configurable labels we use CreateProcessLabels function from pkg/option. Arguably putting it in the option package is not perfect, but the metrics package shouldn't depend on option and I didn't want to introduce a separate package at this stage. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
lambdanis
force-pushed
the
pr/lambdanis/metrics-labels-little-refactoring
branch
from
c988972 to
52475e7
Compare
kkourt
approved these changes
Apr 25, 2024
lambdanis
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another little refactoring of the metrics label filter logic. The idea behind it is that we can have multiple groups of configurable labels, each one with defaults and helper functions for creating a labels struct. I reorganized the code a bit to enable easy creation of different groups of labels, configurable with different options. Notable changes: