Extend metrics library #2606
Merged
Extend metrics library #2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdanis
added
area/metrics
This was referenced Jun 24, 2024
Closed
|
I pushed some commits with small fixes. I will squash the commits after the review, just didn't want to force push now. |
kkourt
reviewed
Jul 2, 2024
| // - cardinality can be constrained | ||
| // - support for configurable labels | ||
| // - metric is initialized at startup for known label values | ||
| // - metric is automatically included in generated docs |
There was a problem hiding this comment.
Is it the case then that granular metrics are metrics with the above properties?
lambdanis
force-pushed
the
pr/lambdanis/library
branch
from
18c500c to
8fd8005
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kkourt
approved these changes
Jul 3, 2024
Sure, I think I'll squash all commits following "Extend metrics library" into it. I separated some code reshuffling into the first commit, so that it's clearer what code is new and what is just moved. |
lambdanis
force-pushed
the
pr/lambdanis/library
branch
from
8fd8005 to
4d945f8
Compare
|
I added two commits with fixes, will squash them too. |
lambdanis
force-pushed
the
pr/lambdanis/library
branch
from
a33529c to
0f522fc
Compare
This commit is a preparation for the further extension of pkg/metrics. There are no functional changes, only moving code around: - moved helpers for creating metrics from metricwithpod.go and granularmetric.go to per-type files: counter.go, gauge.go and histogram.go - renamed labels.go to filteredlabels.go Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
This is a general rewrite of pkg/metrics library, but it a fully backwards compatible way. Goals and key components are described in doc.go. Fixes: #2376 Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
lambdanis
force-pushed
the
pr/lambdanis/library
branch
from
0f522fc to
e0284e8
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a general rewrite of
pkg/metricslibrary, but it a fully backwardscompatible way. Goals and key components are described in
doc.go, so I wouldsuggest starting the review there :)
Here is the Tetragon metrics framework proposal, covering the bigger picture including future plans. The "Goals" and "Proposal/Library" sections are copied into
doc.go.For usage examples see #2604 (defining health metrics group, migrating some custom metrics & collectors to the new interface).
Fixes: #2376